dcapwell commented on code in PR #2784:
URL: https://github.com/apache/cassandra/pull/2784#discussion_r1353056917
##########
conf/cassandra.yaml:
##########
@@ -2113,3 +2110,16 @@ accord_transactions_enabled: false
# a stable cluster. If a node from a previous version was started by
accident we won't any longer toggle behaviors as when UPGRADING.
#
storage_compatibility_mode: NONE
+
+# accord:
+# Enables the execution of Accord (multi-key) transactions on this node.
Review Comment:
spacing is off, and should we add a `#` in front so users can block
uncomment and have this still work? We don't really have many examples of
nested properties with comments inside the nesting... so this could be the
first time this could cause confusion I think.
##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -1129,6 +1123,8 @@ public enum PaxosOnLinearizabilityViolation
*/
public ParameterizedClass default_compaction = null;
+ public AccordSpec accord = new AccordSpec();
Review Comment:
`final`
##########
src/java/org/apache/cassandra/config/AccordSpec.java:
##########
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.config;
+
+public class AccordSpec
+{
+ public volatile boolean enabled = false;
+
+ public volatile String journal_directory;
+
+ public volatile OptionaldPositiveInt shard_count =
OptionaldPositiveInt.UNDEFINED;
+
+ public volatile DurationSpec.IntSecondsBound progress_log_schedule_delay =
new DurationSpec.IntSecondsBound(1);
Review Comment:
unless we plan to have JMX/VTable overrides of these properties, we should
not add `volatile`... For example `enabled` can not change during the life of
the JVM as we only add the accord tables on boot... same for most of these
configs, they are init only
##########
test/conf/cassandra-mtls.yaml:
##########
@@ -87,3 +86,5 @@ authenticator:
class_name : org.apache.cassandra.auth.MutualTlsAuthenticator
parameters :
validator_class_name: org.apache.cassandra.auth.SpiffeCertificateValidator
+accord:
+ journal_directory: build/test/cassandra/accord_journal
Review Comment:
FYI, you can also do
```
accord.journal_directory: build/test/cassandra/accord_journal
```
No need to change, was mostly saying as it might have been faster for you
when you first changed these, so thought to mention
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
