jasonstack commented on code in PR #2771:
URL: https://github.com/apache/cassandra/pull/2771#discussion_r1353843761
##########
src/java/org/apache/cassandra/index/SecondaryIndexManager.java:
##########
@@ -1329,15 +1329,18 @@ private Index unregisterIndex(String name)
if (removed != null)
Review Comment:
An alternative approach would be:
- add `public void unregisterIndex(Index removed, Object groupKey)` to
`IndexRegistry`, similar to existing `IndexRegistry#registerIndex(Index index,
Object groupKey, Supplier<Index.Group> groupSupplier)`.
- add `public void unregister(IndexRegistry registry)` to `Index`, similar
to existing `Index#registry`. Each index implementation will call index
registry to unregister itself with proper `groupKey`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
