mike-tr-adamson commented on code in PR #2769:
URL: https://github.com/apache/cassandra/pull/2769#discussion_r1362486094
##########
src/java/org/apache/cassandra/index/SingletonIndexGroup.java:
##########
@@ -42,13 +44,11 @@
*/
public class SingletonIndexGroup implements Index.Group
{
- private final Index delegate;
- private final Set<Index> indexes;
+ private volatile Index delegate;
Review Comment:
I have reverted the `SingletonIndexGroup` to the simple case and have added
the `isSingleton` method. I tried some other routes but always ended up with
needing some form of synchronization. The `isSingleton` means that
`unregisterIndex` works for either case without special knowledge of the group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
