Mmuzaf commented on code in PR #96:
URL: https://github.com/apache/cassandra-builds/pull/96#discussion_r1354745603
##########
cassandra-release/prepare_release.sh:
##########
@@ -245,7 +245,7 @@ then
execute "cd cassandra"
execute "git checkout $release-tentative"
execute "ant realclean"
- execute "ant publish -Drelease=true -Dbase.version=$release"
+ execute "ant publish -Drelease=true -Dno-checkstyle=true -Drat.skip=true
-Dant.gen-doc.skip=true"
Review Comment:
According to the script name and the action "publish", this is the release
preparation step, why don't we need the `gen-doc` step?
We can replace `-Dno-checkstyle=true -Drat.skip=true` with
`-Dcheck.skip=true` this will allow us to skip everything above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
