jmckenzie-dev commented on code in PR #96:
URL: https://github.com/apache/cassandra-builds/pull/96#discussion_r1360680836
##########
build-scripts/cassandra-test.sh:
##########
@@ -88,6 +88,11 @@ _main() {
local -r version=$(grep 'property\s*name=\"base.version\"' build.xml |sed
-ne 's/.*value=\"\([^"]*\)\".*/\1/p')
local -r regx_version="(2.2|3.0|3.11|4.0|4.1)(.([0-9]+))?$"
+ if [[ $version =~ $regx_version ]] ; then
+ echo "This script is deprecated, having been migrated to be in-tree
since 5.0"
Review Comment:
Same as above.
##########
docker/build-debs.sh:
##########
@@ -13,8 +13,10 @@ fi
[ "x${CASSANDRA_DIR}" != "x" ] || { echo >&2 "CASSANDRA_DIR needs to be
defined"; exit 1; }
[ -d "${CASSANDRA_DIR}" ] || { echo >&2 "Directory ${CASSANDRA_DIR} must
exist"; exit 1; }
+# This script is deprecated, having been migrated to be in-tree since 5.0
Review Comment:
Same as above - link to new script? Or name?
##########
build-scripts/cassandra-dtest-pytest.sh:
##########
@@ -31,6 +31,12 @@ command -v virtualenv >/dev/null 2>&1 || { echo >&2
"virtualenv needs to be inst
java_version=$(java -version 2>&1 | awk -F '"' '/version/ {print $2}' | awk
-F. '{print $1}')
version=$(grep 'property\s*name=\"base.version\"' build.xml |sed -ne
's/.*value=\"\([^"]*\)\".*/\1/p')
+regx_version="(2.2|3.0|3.11|4.0|4.1)(.([0-9]+))?$"
+
+if [[ $version =~ $regx_version ]] ; then
+ echo "This script is deprecated, having been migrated to be in-tree since
5.0"
Review Comment:
nit: leave name of new script so folks know where to look?
##########
docker/build-rpms.sh:
##########
@@ -15,7 +15,10 @@ fi
[ "x${CASSANDRA_DIR}" != "x" ] || { echo >&2 "CASSANDRA_DIR needs to be
defined"; exit 1; }
[ -d "${CASSANDRA_DIR}" ] || { echo >&2 "Directory ${CASSANDRA_DIR} must
exist"; exit 1; }
+# This script is deprecated, having been migrated to be in-tree since 5.0
Review Comment:
link?
##########
cassandra-release/prepare_release.sh:
##########
@@ -326,21 +332,28 @@ then
execute "cd $rpm_package_dir"
echo "Building redhat packages ..." 1>&3 2>&4
+ execute "mkdir $tmp_dir/cassandra-dist-dev/${release}/redhat"
Review Comment:
Make note to create a follow up JIRA for it perhaps?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
