Mmuzaf commented on code in PR #237:
URL: https://github.com/apache/cassandra-dtest/pull/237#discussion_r1358266695


##########
sstable_generation_loading_test.py:
##########
@@ -35,10 +35,10 @@ def compact(self):
         return self.fixture_dtest_setup.cluster.version() < MAJOR_VERSION_4 
and self.test_compact
 
     def create_schema(self, session, ks, compression):
+        legacy_compression_class = self.fixture_dtest_setup.cluster.version() 
< MAJOR_VERSION_3

Review Comment:
   The cassandra-18742 patch is fixed as of 5.0, so the obsolete param should 
work for versions < 5.0, right? I wonder if we can fix this condition...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to