smiklosovic commented on code in PR #237:
URL: https://github.com/apache/cassandra-dtest/pull/237#discussion_r1358358399
##########
sstable_generation_loading_test.py:
##########
@@ -35,10 +35,10 @@ def compact(self):
return self.fixture_dtest_setup.cluster.version() < MAJOR_VERSION_4
and self.test_compact
def create_schema(self, session, ks, compression):
+ legacy_compression_class = self.fixture_dtest_setup.cluster.version()
< MAJOR_VERSION_3
Review Comment:
@Mmuzaf yes, you are technically right, it will work with
`sstable_compression` until 5.0 but I am thinking .... why not to use
non-deprecated param already for all branches which support it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
