adelapena commented on code in PR #2673:
URL: https://github.com/apache/cassandra/pull/2673#discussion_r1363743988
##########
src/java/org/apache/cassandra/cql3/statements/SelectStatement.java:
##########
@@ -1295,8 +1378,10 @@ private Term prepareLimit(VariableSpecifications
boundNames, Term.Raw limit,
return prepLimit;
}
- private static void verifyOrderingIsAllowed(StatementRestrictions
restrictions) throws InvalidRequestException
+ private static void verifyOrderingIsAllowed(StatementRestrictions
restrictions, Map<ColumnMetadata, Ordering> orderingColumns) throws
InvalidRequestException
Review Comment:
When users try to use not-ANN `ORDER BY` they get an error that says `ORDER
BY with 2ndary indexes is not supported`. However, now we will support `ORDER
BY ... ANN OF` with 2ndary indexes.
So the message should probably say something like `ORDER BY with 2ndary
indexes is not supported, except for ANN queries`, or something like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
