mike-tr-adamson commented on code in PR #2673:
URL: https://github.com/apache/cassandra/pull/2673#discussion_r1368551933
##########
src/java/org/apache/cassandra/index/sai/disk/v1/MemtableIndexWriter.java:
##########
@@ -184,4 +179,43 @@ private long flush(PrimaryKey minKey,
return numRows;
}
+
+ private void flushVectorIndex(long startTime, Stopwatch stopwatch) throws
IOException
+ {
+ SegmentMetadata.ComponentMetadataMap metadataMap =
memtable.writeDirect(indexDescriptor, indexContext, rowMapping::get);
+
+ completeIndexFlush(rowMapping.size(), startTime, stopwatch);
+
+ SegmentMetadata metadata = new SegmentMetadata(0,
+ rowMapping.size(),
+ 0,
+
rowMapping.maxSSTableRowId,
+ rowMapping.minKey,
+ rowMapping.maxKey,
+
ByteBufferUtil.bytes(0), // VSTODO by pass min max terms for vectors
Review Comment:
It isn't really a TODO any more but we could eventually tidy this so we
could just not pass anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
