ekaterinadimitrova2 commented on code in PR #2807:
URL: https://github.com/apache/cassandra/pull/2807#discussion_r1364003391
##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -171,6 +171,20 @@ public static Set<String> splitCommaDelimited(String src)
public volatile DurationSpec.LongMillisecondsBound
stream_transfer_task_timeout = new DurationSpec.LongMillisecondsBound("12h");
+ public volatile DurationSpec.LongMillisecondsBound cms_await_timeout = new
DurationSpec.LongMillisecondsBound("120000ms");
+ public volatile int cms_default_max_retries = 10;
+ public volatile DurationSpec.IntMillisecondsBound
cms_default_retry_backoff = new DurationSpec.IntMillisecondsBound("50ms");
Review Comment:
A quick look shows me we have diverged from using `initial_` to `default_`
in the past year in the `Config` class. Now, we are inconsistent. The precedent
was not created in this patch; sadly, as it could be confusing to people, it
happened. I leave it up to you; naming is hard in general.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
