blerer commented on code in PR #2807: URL: https://github.com/apache/cassandra/pull/2807#discussion_r1365225732
########## src/java/org/apache/cassandra/tcm/extensions/AbstractExtensionValue.java: ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.tcm.extensions; + +import java.io.IOException; + +import org.apache.cassandra.io.util.DataInputPlus; +import org.apache.cassandra.io.util.DataOutputPlus; +import org.apache.cassandra.tcm.Epoch; +import org.apache.cassandra.tcm.serialization.Version; + +public abstract class AbstractExtensionValue<V> implements ExtensionValue<V> +{ + private Epoch lastModified = Epoch.EMPTY; + private V value = null; + + @Override + public V withLastModified(Epoch lastModified) + { + this.lastModified = lastModified; + return (V)this; Review Comment: This method is broken for its sub-classes. For example `IntValue` will attempt to cast an `IntValue` object into an `Integer`. There is also a change in the class expectation outside of `ExtensionValue` classes all others `MetadataValue` seems to be immutable. I think that it would make sense to keep that immutability everywhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
