pkolaczk commented on code in PR #2556:
URL: https://github.com/apache/cassandra/pull/2556#discussion_r1370142020
##########
src/java/org/apache/cassandra/cql3/restrictions/SingleColumnRestriction.java:
##########
@@ -414,38 +398,56 @@ protected boolean isSupportedBy(Index index)
@Override
public String toString()
{
- return String.format("SLICE%s", slice);
+ return String.format("SLICE{%s, NOT IN %s}", slice, skippedValues);
}
- private SliceRestriction(ColumnMetadata columnDef, TermSlice slice)
- {
- super(columnDef);
- this.slice = slice;
- }
}
- // This holds CONTAINS, CONTAINS_KEY, and map[key] = value restrictions
because we might want to have any combination of them.
+
+ // This holds CONTAINS, CONTAINS_KEY, NOT CONTAINS, NOT CONTAINS KEY and
map[key] = value restrictions because we might want to have any combination of
them.
public static final class ContainsRestriction extends
SingleColumnRestriction
{
private final List<Term> values = new ArrayList<>(); // for CONTAINS
- private final List<Term> keys = new ArrayList<>(); // for CONTAINS_KEY
- private final List<Term> entryKeys = new ArrayList<>(); // for
map[key] = value
+ private final List<Term> negativeValues = new ArrayList<>(); // for
NOT_CONTAINS
+ private List<Term> keys = new ArrayList<>(); // for CONTAINS_KEY
+ private final List<Term> negativeKeys = new ArrayList<>(); // for
NOT_CONTAINS_KEY
+ private List<Term> entryKeys = new ArrayList<>(); // for map[key] =
value
private final List<Term> entryValues = new ArrayList<>(); // for
map[key] = value
+ private List<Term> negativeEntryKeys = new ArrayList<>(); // for
map[key] != value
+ private List<Term> negativeEntryValues = new ArrayList<>(); // for
map[key] != value
Review Comment:
Indeed. Applied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
