adelapena commented on code in PR #2556:
URL: https://github.com/apache/cassandra/pull/2556#discussion_r1378894570
##########
src/java/org/apache/cassandra/cql3/restrictions/TermSlice.java:
##########
@@ -28,6 +28,12 @@
final class TermSlice
{
+ /**
Review Comment:
It seems that `SELECT * FROM t WHERE v!=0` still requires `ALLOW FILTERING`
after the last changes. The new check on
`AllowFilteringTest#testAllowFilteringOnFirstClusteringKeyColumn` makes the
test fail.
Also, `AllowFilteringTest` has test methods for different schemas. We should
probably add the `NEQ` check to all the test methods, not only in
`testAllowFilteringOnFirstClusteringKeyColumn`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
