adelapena commented on code in PR #2673:
URL: https://github.com/apache/cassandra/pull/2673#discussion_r1370489241
##########
src/java/org/apache/cassandra/index/sai/disk/PrimaryKeyMap.java:
##########
@@ -70,6 +71,22 @@ default void close()
*/
long rowIdFromPrimaryKey(PrimaryKey key);
+ /**
+ * Returns the first row ID for a given token or a negative value if not
found
+ *
+ * @param token the {@link Token} to lookup
+ * @return the first row ID associated with the {@link Token} or a
negative value
+ */
+ long ceiling(Token token);
+
+ /**
+ * Returns the last row ID for a given partition range or the previous row
ID if there was no match for the partition range
Review Comment:
Yes, I think the original code uses something `the row ID of the least PK
greater than or equal to the given PK` for ceiling, and `the row ID of the
greatest PK less than or equal to the given PK`, which sounds clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
