adelapena commented on code in PR #2673:
URL: https://github.com/apache/cassandra/pull/2673#discussion_r1370603612
##########
src/java/org/apache/cassandra/cql3/restrictions/StatementRestrictions.java:
##########
@@ -476,6 +507,38 @@ public boolean usesSecondaryIndexing()
return this.usesSecondaryIndexing;
}
+ /**
+ * This is a hack to push ordering down to indexes.
+ * Indexes are selected based on RowFilter only, so we need to turn
orderings into restrictions
+ * so they end up in the row filter.
+ *
+ * @param orderings orderings from the select statement
+ * @return the {@link RestrictionSet} with the added orderings
+ */
+ private RestrictionSet addOrderingRestrictions(List<Ordering> orderings,
RestrictionSet restrictionSet)
+ {
+ List<Ordering> annOrderings = orderings.stream().filter(o ->
o.expression.hasNonClusteredOrdering()).collect(Collectors.toList());
+
+ if (annOrderings.size() > 1)
+ throw new InvalidRequestException("Cannot specify more than one
ANN ordering");
+ else if (annOrderings.size() == 1)
+ {
+ if (orderings.size() > 1)
+ throw new InvalidRequestException("ANN ordering does not
support secondary ordering");
Review Comment:
I think we are still missing this one in the last batch of commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
