blerer commented on code in PR #2655:
URL: https://github.com/apache/cassandra/pull/2655#discussion_r1378619517
##########
src/java/org/apache/cassandra/db/marshal/SetType.java:
##########
@@ -243,4 +243,18 @@ public ByteBuffer getMaskedValue()
{
return decompose(Collections.emptySet());
}
+
+ @Override
+ public List<ByteBuffer> filterSortAndValidateElements(List<ByteBuffer>
buffers)
+ {
+ SortedSet<ByteBuffer> sorted = new TreeSet<>(elements);
+ for (ByteBuffer buffer: buffers)
+ {
+ if (buffer == null)
+ throw new MarshalException("null is not supported inside
collections");
+ elements.validate(buffer);
Review Comment:
This test is simply not needed for now. Collections do not support element
bind markers so you cannot provide an unset element.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
