Maxwell-Guo commented on code in PR #2655: URL: https://github.com/apache/cassandra/pull/2655#discussion_r1328209944
########## src/java/org/apache/cassandra/cql3/MultiElements.java: ########## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.cql3; + +import java.nio.ByteBuffer; +import java.util.ArrayList; +import java.util.List; + +import org.apache.cassandra.cql3.functions.Function; +import org.apache.cassandra.db.marshal.MultiElementType; +import org.apache.cassandra.exceptions.InvalidRequestException; +import org.apache.cassandra.serializers.MarshalException; + +/** + * Static classes for MultiElementTypes. + */ +public final class MultiElements +{ + private MultiElements() + { + } + + /** + * The serialized elements a multi-element type (collection, tuple, udt, ...) + */ + public static class Value extends Term.Terminal + { + /** + * The type represented by this {@code Value} + */ + private final MultiElementType<?> type; + + /** + * The serialized values of the elements composing this value. + */ + private final List<ByteBuffer> elements; + + /** + * Creates a {@code Value} from its serialized representation. + * + * @param value a serialized value from the specified type + * @param type the value type + * @return a {@code Value} + */ + public static Value fromSerialized(ByteBuffer value, MultiElementType<?> type) + { + try + { + // We depend for SetType and MapType on the collections being without duplicated keys and sorted. + return new Value(type, type.filterSortAndValidateElements(type.unpack(value))); + } + catch (MarshalException e) + { + throw new InvalidRequestException(e.getMessage()); + } + } + + public Value(MultiElementType<?> type, List<ByteBuffer> elements) + { + this.type = type; + this.elements = elements; + } + + @Override + public ByteBuffer get() + { + return type.pack(elements); + } + + @Override + public List<ByteBuffer> getElements() + { + return elements; + } + } + + /** + * The terms representing a multi-element value (collection, tuple, udt, ...) where at least one of the terms + * represent a non-pure functions or a bind marker. + */ + public static class DelayedValue extends Term.NonTerminal + { + /** + * The type represented by this {@code DelayedValue} + */ + private final MultiElementType<?> type; + + /** + * The terms representing the elements composing this value. + */ + private final List<Term> elements; + + public DelayedValue(MultiElementType<?> type, List<Term> elements) + { + this.type = type; + this.elements = elements; + } + + @Override + public void collectMarkerSpecification(VariableSpecifications boundNames) + { + if (type.supportElementBindMarkers()) + { + for (int i = 0, m = elements.size(); i < m; i++) + elements.get(i).collectMarkerSpecification(boundNames); + } + } + + @Override + public Terminal bind(QueryOptions options) + { + try + { + List<ByteBuffer> buffers = new ArrayList<ByteBuffer>(elements.size()); + for (Term t : elements) + { + buffers.add(t.bindAndGet(options)); + } + + buffers = type.filterSortAndValidateElements(buffers); + return new Value(type, buffers); + } + catch (MarshalException e) + { + throw new InvalidRequestException(e.getMessage()); Review Comment: can we use "throw invalidRequest(" here too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
