adelapena commented on code in PR #2655: URL: https://github.com/apache/cassandra/pull/2655#discussion_r1378920111
########## src/java/org/apache/cassandra/serializers/MapSerializer.java: ########## @@ -21,6 +21,7 @@ import java.nio.BufferUnderflowException; import java.nio.ByteBuffer; import java.util.ArrayList; +import java.util.Collection; Review Comment: That second check looks like dead code that was forgotten when fixing the validation method during CASSANDRA-18504. There is an identical situation in `SetSerializer`. This is unrelated to the changes on this PR but, since we are here, we could just remove the two `if (accessor.isEmpty(input)) return;` lines. This would save us the overhead of a separate trivial ticket, if that's ok with you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
