amitdpawar commented on PR #2777: URL: https://github.com/apache/cassandra/pull/2777#issuecomment-1805592701
> I've left some comments and questions. Other than that, just as it was already mentioned, we need a test for the `DirectIOSegment` - it could be a unit test with mocking most of the stuff. We really need to have a coverage of that alignment related stuff. It looks correct as I was reviewing, but additional test is required. I suggest implement it using quick theories so that we catch the edge cases. > > Additionally, it would be great to have some test which can verify different configuration paths. > > We are open to help you with testing and other stuff, feel free to ask. > > I'm going to modify the default configuration to use the direct IO for commit log and run the tests then so that we can be sure that new functionality is in use. I didn't realize and it may take more time to do all these changes. Definitely need your help. I request you to do all the necessary changes required to upstream this patch. If anything is required from my side, then please let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
