amitdpawar commented on PR #2777: URL: https://github.com/apache/cassandra/pull/2777#issuecomment-1802077105
Summary of changes done to this PR. 1. Moved file initialization from DirectIOSegment constructor to CommitLogSegment.writeLogHeader function. This is required from correctness and performance point of view for each file. 2. Enabled "SimpleCachedBufferPool" pool to re-use the buffers as suggested by "Ariel Weisberg" during initial review of this ticket. Need to identify Java minimum alignment to use this feature during startup and need to pass this value to same class to allocate the additional bytes to slice the buffer. Please review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
