Maxwell-Guo commented on code in PR #2879:
URL: https://github.com/apache/cassandra/pull/2879#discussion_r1389457901
##########
conf/cassandra.yaml:
##########
@@ -1038,11 +1045,11 @@ snapshot_links_per_second: 0
# large rows, or a very large number of rows per partition are
# present, it is recommended to increase the index granularity
# or switch to the BTI SSTable format.
-#
+# The original name of this configuration is colum_index_size.
# Leave undefined to use a default suitable for the SSTable format
# in use (64 KiB for BIG, 16KiB for BTI).
# Min unit: KiB
-# column_index_size: 4KiB
+# row_index_granularity: 4KiB
Review Comment:
ok
##########
src/java/org/apache/cassandra/io/sstable/format/AbstractSSTableFormat.java:
##########
@@ -32,6 +32,33 @@ protected AbstractSSTableFormat(String name, Map<String,
String> options)
this.options = options;
}
+ public enum Option
Review Comment:
Yes, at first, I set it up separately in big and bti format. But I found
that the two have some common options, so my initial idea is that
AbstractSSTableFormat includes all, and then different formats are selectively
supported based on their own capabilities. For those that are not supported,
exceptions are thrown. see the [test here
](https://github.com/Maxwell-Guo/cassandra/blob/CASSANDRA-18533/test/unit/org/apache/cassandra/io/sstable/SSTableFormatTest.java#L388)
But after read your comment on ["I would keep it simple and not add a common
settings entry under options. If necessary, the user can copy the value to
both."](https://issues.apache.org/jira/browse/CASSANDRA-18533) ,I think it's
better to change the option to individual format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
