blambov commented on code in PR #2879:
URL: https://github.com/apache/cassandra/pull/2879#discussion_r1413975798
##########
src/java/org/apache/cassandra/io/sstable/indexsummary/IndexSummaryManager.java:
##########
@@ -99,24 +106,26 @@ private IndexSummaryManager(Supplier<List<T>>
indexSummariesProvider)
this.indexSummariesProvider = indexSummariesProvider;
executor = executorFactory().scheduled(false, "IndexSummaryManager",
Thread.MIN_PRIORITY);
-
- long indexSummarySizeInMB =
DatabaseDescriptor.getIndexSummaryCapacityInMiB();
- int interval =
DatabaseDescriptor.getIndexSummaryResizeIntervalInMinutes();
+ // TODO make format get from default format
+ format = DatabaseDescriptor.getSelectedSSTableFormat();
Review Comment:
I don't want to overthink it, especially as there is only one format that
uses these at the moment -- if there are multiple and they don't match, we
should raise an exception during startup / the validation of the yaml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
