dcapwell commented on code in PR #65:
URL: https://github.com/apache/cassandra-accord/pull/65#discussion_r1391242710
##########
accord-core/src/main/java/accord/impl/InMemoryCommandStore.java:
##########
@@ -92,6 +94,11 @@ public abstract class InMemoryCommandStore extends
CommandStore
private final TreeMap<TxnId, RangeCommand> rangeCommands = new TreeMap<>();
private final TreeMap<TxnId, Ranges> historicalRangeCommands = new
TreeMap<>();
+ /**
+ * Since this cache is fully in-memory the store does not hit states that
most stores will; that data is not in-memory!
+ * To simulate such behaviors, a "cache" is used to state what is
in-memory vs what needs to be loaded.
+ */
+ private final Set<Object> cache = new LinkedHashSet<>();
Review Comment:
I'll try to understand `commandStore.canExposeUnloaded()` and get back to
you. This looks to be a store property and not based off the requested data...
I added the cache logic as I noticed that the Cassandra logic was
drastically different than InMemory logic, and we kept having logic optimized
for InMemory logic... so I wanted to get the 2 stores closer as majority of
testing is in BurnTest and far less is done with Cassandra...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
