bdeggleston commented on code in PR #65:
URL: https://github.com/apache/cassandra-accord/pull/65#discussion_r1394956498
##########
accord-core/src/main/java/accord/coordinate/CoordinatePreAccept.java:
##########
@@ -250,6 +250,16 @@ void onNewEpoch(Topologies prevTopologies, Timestamp
executeAt, List<PreAcceptOk
// TODO (desired, efficiency): check if we have already have a valid
quorum for the future epoch
// (noting that nodes may have adopted new ranges, in which case they
should be discounted, and quorums may have changed shape)
node.withEpoch(executeAt.epoch(), () -> {
+ TopologyMismatch mismatch =
TopologyMismatch.checkForMismatch(node.topology().globalForEpoch(executeAt.epoch()),
txnId, route.homeKey(), txn.keys());
+ if (mismatch != null)
+ {
+ Invalidate.invalidate(node, txnId, route, (outcome, failure)
-> {
Review Comment:
so presumably we're invalidating this txn because it contains keys that
don't intersect with the accord topology, ie: are unreplicated from the
perspective of accord. If we try to invalidate with those same keys, won't the
invalidation be unable to make progress because it's trying to find replicas
for unreplicated keys?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
