jacek-lewandowski commented on code in PR #2894:
URL: https://github.com/apache/cassandra/pull/2894#discussion_r1403998950
##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -1415,6 +1426,52 @@ public static void applyPartitioner(Config conf)
paritionerName = partitioner.getClass().getCanonicalName();
}
+ private static DiskAccessMode
resolveCommitLogWriteDiskAccessMode(DiskAccessMode providedDiskAccessMode)
+ {
+ boolean compressOrEncrypt = getCommitLogCompression() != null ||
(getEncryptionContext() != null && getEncryptionContext().isEnabled());
+ boolean directIOSupported = false;
+ try
+ {
+ directIOSupported = FileUtils.getBlockSize(new
File(getCommitLogLocation())) > 0;
Review Comment:
I'm not sure - why JDK version? 5.0 runs on 11+ and we do that not because
of JDK but rather because that some file systems does not have "block size",
for example in memory fs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
