Maxwell-Guo commented on code in PR #2894:
URL: https://github.com/apache/cassandra/pull/2894#discussion_r1404000173
##########
src/java/org/apache/cassandra/db/commitlog/MemoryMappedSegment.java:
##########
@@ -35,21 +40,24 @@
*/
public class MemoryMappedSegment extends CommitLogSegment
{
+ private final int fd;
+
/**
* Constructs a new segment file.
- *
- * @param commitLog the commit log it will be used with.
*/
- MemoryMappedSegment(CommitLog commitLog, AbstractCommitLogSegmentManager
manager)
+ MemoryMappedSegment(AbstractCommitLogSegmentManager manager,
ThrowingFunction<Path, FileChannel, IOException> channelFactory)
{
- super(commitLog, manager);
+ super(manager, channelFactory);
// mark the initial sync marker as uninitialised
int firstSync = buffer.position();
buffer.putInt(firstSync + 0, 0);
buffer.putInt(firstSync + 4, 0);
+
Review Comment:
what about delete this line : 55
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
