beobal commented on code in PR #245:
URL: https://github.com/apache/cassandra-dtest/pull/245#discussion_r1406027256
##########
upgrade_tests/upgrade_through_versions_test.py:
##########
@@ -497,7 +497,7 @@ def upgrade_scenario(self, populate=True,
create_schema=True, rolling=False, aft
self._check_counters()
self._check_select_count()
- if self.cluster.version() >= '5.1':
+ if self.cluster.nodelist()[0].get_cassandra_version() >= '5.1':
Review Comment:
This I don't believe is correct. I can see no valid reason why the cluster
would be on 5.1 but node1 would not be & in fact that would constitute a
failure at this point in the test.
##########
upgrade_tests/storage_engine_upgrade_test.py:
##########
@@ -69,7 +69,7 @@ def _do_upgrade(self, login_keyspace=True):
node1.set_install_dir(install_dir=self.fixture_dtest_setup.default_install_dir)
self.install_legacy_parsing(node1)
node1.start(wait_for_binary_proto=True)
- if self.dtest_config.cassandra_version_from_build >= MAJOR_VERSION_5:
+ if node1.get_cassandra_version() >= '5.1':
Review Comment:
This seems to be the cause of all the failures in CASSANDRA-19099, we missed
this when bumping TCM from 5.0 to 5.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
