michaelsembwever commented on code in PR #245:
URL: https://github.com/apache/cassandra-dtest/pull/245#discussion_r1406032998


##########
upgrade_tests/upgrade_through_versions_test.py:
##########
@@ -497,7 +497,7 @@ def upgrade_scenario(self, populate=True, 
create_schema=True, rolling=False, aft
                 self._check_counters()
                 self._check_select_count()
 
-        if self.cluster.version() >= '5.1':
+        if self.cluster.nodelist()[0].get_cassandra_version() >= '5.1':

Review Comment:
   we can do forward upgrade tests.
   so the cluster is configured with 5.0, and then one node is upgraded to 5.1
   
   
   and the guarded line is specific to that node 🤷 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to