mike-tr-adamson commented on code in PR #2943:
URL: https://github.com/apache/cassandra/pull/2943#discussion_r1410957320
##########
src/java/org/apache/cassandra/index/sai/disk/format/IndexComponent.java:
##########
@@ -73,7 +73,12 @@ public enum IndexComponent
TOKEN_VALUES("TokenValues"),
/**
- * An on-disk block packed index containing the starting and ending rowIds
for each partition.
+ * An on-disk block packed index mapping rowIds to partitionIds.
+ */
+ PARTITION_ROWS("PartitionRows"),
+
+ /**
+ * An on-disk block packed index containing the partition size for each
partition keyed by partitionId.
Review Comment:
This was on my list to look at the naming and associated comments of these
on-disk components. I have gone with renaming all of them to make it clearer
exactly what they contain. I have also made sure the users of these (in the
primary key maps) are correctly named and commented.
I have to admit I was getting confused by the naming and what they were
meant to be doing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
