mike-tr-adamson commented on code in PR #2943: URL: https://github.com/apache/cassandra/pull/2943#discussion_r1411828579
########## test/unit/org/apache/cassandra/index/sai/cql/RandomIntersectionTest.java: ########## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.index.sai.cql; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.Comparator; +import java.util.HashMap; +import java.util.LinkedList; +import java.util.List; +import java.util.Map; +import java.util.Objects; +import java.util.stream.Collectors; + +import org.junit.Before; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; + +import org.apache.cassandra.index.sai.utils.SAIRandomizedTester; + +@RunWith(Parameterized.class) +public class RandomIntersectionTest extends SAIRandomizedTester +{ + private static final Object[][] EMPTY_ROWS = new Object[][]{}; + + @Parameterized.Parameter + public String testName; + + @Parameterized.Parameter(1) + public boolean partitionRestricted; + + @Parameterized.Parameter(2) + public boolean largePartition; + + @Parameterized.Parameter(3) + public boolean v1Cardinality; + + @Parameterized.Parameter(4) + public boolean v2Cardinality; + + @Parameterized.Parameters(name = "{0}") + public static List<Object[]> parameters() + { + List<Object[]> parameters = new LinkedList<>(); + + parameters.add(new Object[]{ "Large partition restricted high high", true, true, true, true }); + parameters.add(new Object[]{ "Large partition restricted low low", true, true, false, false }); + parameters.add(new Object[]{ "Large partition restricted high low", true, true, true, false }); + parameters.add(new Object[]{ "Large partition unrestricted high high", false, true, true, true }); + parameters.add(new Object[]{ "Large partition unrestricted low low", false, true, false, false }); + parameters.add(new Object[]{ "Large partition unrestricted high low", false, true, true, false }); + parameters.add(new Object[]{ "Small partition restricted high high", true, false, true, true }); + parameters.add(new Object[]{ "Small partition restricted low low", true, false, false, false }); + parameters.add(new Object[]{ "Small partition restricted high low", true, false, true, false }); + parameters.add(new Object[]{ "Small partition unrestricted high high", false, false, true, true }); + parameters.add(new Object[]{ "Small partition unrestricted low low", false, false, false, false }); + parameters.add(new Object[]{ "Small partition unrestricted high low", false, false, true, false }); + + return parameters; + } + + private int numRows; + + @Before + public void createTableAndIndexes() + { + createTable("CREATE TABLE %s (pk int, ck int, v1 int, v2 int, PRIMARY KEY(pk, ck))"); + createIndex("CREATE INDEX ON %s(v1) USING 'sai'"); + createIndex("CREATE INDEX ON %s(v2) USING 'sai'"); + + numRows = nextInt(50000, 200000); + } + + @Test + public void randomIntersectionTest() throws Throwable + { + if (partitionRestricted) + runRestrictedQueries(); + else + runUnrestrictedQueries(); + } + + private void runRestrictedQueries() throws Throwable + { + Map<Integer, List<TestRow>> testRowMap = buildAndLoadTestRows(); + + beforeAndAfterFlush(() -> { + for (int queryCount = 0; queryCount < nextInt(10, 100); queryCount++) + { + int pk = testRowMap.keySet().stream().skip(nextInt(0, testRowMap.size())).findFirst().orElseThrow(); + int v1 = nextInt(10, numRows/10); + int v2 = nextInt(10, numRows/50); + + List<Object[]> expected = testRowMap.get(pk) + .stream() + .sorted(Comparator.comparingInt(o -> o.ck)) + .filter(row -> row.v1 > v1 && row.v2 > v2) + .map(row -> row(row.ck)) + .collect(Collectors.toList()); + + assertRows(execute("SELECT ck FROM %s WHERE pk = ? AND v1 > ? AND v2 > ?", pk, v1, v2), expected.toArray(EMPTY_ROWS)); + } + }); + } + + private void runUnrestrictedQueries() throws Throwable + { + Map<Integer, List<TestRow>> testRowMap = buildAndLoadTestRows(); + + beforeAndAfterFlush(() -> { + for (int queryCount = 0; queryCount < nextInt(10, 100); queryCount++) + { + int v1 = nextV1(); + int v2 = nextV2(); + + List<Object[]> expected = testRowMap.values() + .stream() + .flatMap(Collection::stream) + .filter(row -> row.v1 == v1 && row.v2 == v2) + .map(row -> row(row.ck)) + .collect(Collectors.toList()); + + assertRowsIgnoringOrder(execute("SELECT ck FROM %s WHERE v1 = ? AND v2 = ?", v1, v2), expected.toArray(EMPTY_ROWS)); + } + }); + } + + private Map<Integer, List<TestRow>> buildAndLoadTestRows() + { + Map<Integer, List<TestRow>> testRowMap = new HashMap<>(); + + int clusterSize = largePartition ? nextInt(500, 5000) : nextInt(10, 100); + int partition = nextInt(0, numRows); + List<TestRow> rowList = new ArrayList<>(clusterSize); + testRowMap.put(partition, rowList); + int clusterCount = 0; + for (int index = 0; index < numRows; index++) + { + TestRow row = new TestRow(partition, nextInt(10, numRows), nextV1(), nextV2()); + while (rowList.contains(row)) + row = new TestRow(partition, nextInt(10, numRows), nextV1(), nextV2()); + + rowList.add(row); + clusterCount++; + if (clusterCount == clusterSize) + { + clusterCount = 0; + clusterSize = largePartition ? nextInt(500, 5000) : nextInt(10, 100); + partition = nextInt(0, numRows); + while (testRowMap.containsKey(partition)) + partition = nextInt(0, numRows); + rowList = new ArrayList<>(clusterSize); + testRowMap.put(partition, rowList); + } + } + testRowMap.values().stream().flatMap(Collection::stream).forEach(row -> execute("INSERT INTO %s (pk, ck, v1, v2) VALUES (?, ?, ?, ?)", + row.pk, row.ck, row.v1, row.v2)); + return testRowMap; + } + + private int nextV1() + { + return v1Cardinality ? nextInt(10, numRows/10) : nextInt(10, numRows/1000); + } + + private int nextV2() + { + return v2Cardinality ? nextInt(10, numRows/10) : nextInt(10, numRows/1000); Review Comment: Sorry, missed that. It should be using `nextV1` and `nextV2` in `runRetrictedQueries` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
