blambov commented on code in PR #2879:
URL: https://github.com/apache/cassandra/pull/2879#discussion_r1537854438


##########
src/java/org/apache/cassandra/io/sstable/indexsummary/IndexSummaryManager.java:
##########
@@ -99,24 +106,26 @@ private IndexSummaryManager(Supplier<List<T>> 
indexSummariesProvider)
         this.indexSummariesProvider = indexSummariesProvider;
 
         executor = executorFactory().scheduled(false, "IndexSummaryManager", 
Thread.MIN_PRIORITY);
-
-        long indexSummarySizeInMB = 
DatabaseDescriptor.getIndexSummaryCapacityInMiB();
-        int interval = 
DatabaseDescriptor.getIndexSummaryResizeIntervalInMinutes();
+        // TODO make format get from default format
+        format = DatabaseDescriptor.getSelectedSSTableFormat();

Review Comment:
   We do not want to support per-table configuration at the moment. This means 
that we don't need to support format variations (e.g. bti-fast) either.
   
   However, we should support formats that people can plug into the database by 
linking with a JAR that implements their custom format. We do not know what 
options such formats may use.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to