Maxwell-Guo commented on code in PR #2924:
URL: https://github.com/apache/cassandra/pull/2924#discussion_r1414764152
##########
src/java/org/apache/cassandra/transport/PreV5Handlers.java:
##########
@@ -327,6 +330,13 @@ public void exceptionCaught(final ChannelHandlerContext
ctx, Throwable cause)
logger.debug("Excluding client exception for {}; address
contained in client_error_reporting_exclusions", ctx.channel().remoteAddress(),
cause);
return;
}
+
+ if (Throwables.anyCauseMatches(cause, t -> t instanceof
SSLException))
+ {
+ logger.warn("SSLException in client networking with peer {}
{}", ctx.channel().remoteAddress(), cause.getMessage());
Review Comment:
And if the log is frequent, we can use NoSpamLogger.log.
Besides, what about add some metric like [protocolException
metric](https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/metrics/ClientMetrics.java#L51)has
done, we can separate SSL exceptions from unknownException.
##########
src/java/org/apache/cassandra/transport/PreV5Handlers.java:
##########
@@ -327,6 +330,13 @@ public void exceptionCaught(final ChannelHandlerContext
ctx, Throwable cause)
logger.debug("Excluding client exception for {}; address
contained in client_error_reporting_exclusions", ctx.channel().remoteAddress(),
cause);
return;
}
+
+ if (Throwables.anyCauseMatches(cause, t -> t instanceof
SSLException))
+ {
+ logger.warn("SSLException in client networking with peer {}
{}", ctx.channel().remoteAddress(), cause.getMessage());
Review Comment:
I think it is better to move this part of code into the method
logClientNetworkingExceptions() below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
