Maxwell-Guo commented on code in PR #2924:
URL: https://github.com/apache/cassandra/pull/2924#discussion_r1416564898
##########
src/java/org/apache/cassandra/transport/PreV5Handlers.java:
##########
@@ -327,6 +330,13 @@ public void exceptionCaught(final ChannelHandlerContext
ctx, Throwable cause)
logger.debug("Excluding client exception for {}; address
contained in client_error_reporting_exclusions", ctx.channel().remoteAddress(),
cause);
return;
}
+
+ if (Throwables.anyCauseMatches(cause, t -> t instanceof
SSLException))
+ {
+ logger.warn("SSLException in client networking with peer {}
{}", ctx.channel().remoteAddress(), cause.getMessage());
Review Comment:
> I also added a call to ClientMetrics.instance.markProtocolException();
since it isn't too much trouble.
My personal suggestion is to create a new metric, refer to
protocolexception, but if you are reusing the protocolexception metric, I may
think it is better not to add this metric, as it will cause confusion. I think
SSLexception is different from ProtocolException
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
