szymon-miezal commented on code in PR #2957:
URL: https://github.com/apache/cassandra/pull/2957#discussion_r1415216215
##########
pylib/cqlshlib/copyutil.py:
##########
@@ -2130,6 +2136,7 @@ def convert_unknown(val, ct=cql_type):
'map': convert_map,
'tuple': convert_tuple,
'frozen': convert_single_subtype,
+ VectorType.typename: convert_vector,
Review Comment:
I understand the suggestion to use 'vector' for consistency in coding style.
However, I think there is a value in referencing a const that was defined
somewhere else - in this case in the type definition - instead of repeating it.
This approach makes the connection explicit and easier to track.
From a practical standpoint, it's highly unlikely that the name will change,
as it could introduce a breaking change.
While I may not see significant value in maintaining this consistency in
this particular instance, I won't strongly oppose it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
