szymon-miezal commented on code in PR #2957:
URL: https://github.com/apache/cassandra/pull/2957#discussion_r1415342393
##########
pylib/cqlshlib/copyutil.py:
##########
@@ -2130,6 +2136,7 @@ def convert_unknown(val, ct=cql_type):
'map': convert_map,
'tuple': convert_tuple,
'frozen': convert_single_subtype,
+ VectorType.typename: convert_vector,
Review Comment:
One remark though, the way `vector` type is parsed you won't receive the
`vector` value at
https://github.com/apache/cassandra/pull/2957/files#diff-584645e6e932edd7a17f03c79ae87b1f1f8ed54919a31ce8785af156b89c0b76R2139,
instead it will be `org.apache.cassandra.db.marshal.VectorType`, it comes from
the python driver -
https://github.com/datastax/python-driver/blob/120277da36f880ac6a5508480144fe436bf0d8c1/cassandra/cqltypes.py#L1401.
That's another reason to use `VectorType.typename` instead of a string literal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
