ifesdjeen commented on code in PR #24:
URL: https://github.com/apache/cassandra-harry/pull/24#discussion_r1416260953
##########
harry-core/src/harry/visitors/MutatingVisitor.java:
##########
@@ -116,21 +163,23 @@ public void afterLts(long lts, long pd)
statements.clear();
bindings.clear();
- executeWithRetries(lts, pd, new CompiledStatement(query,
bindingsArray));
+ CompiledStatement compiledStatement = new CompiledStatement(query,
bindingsArray);
+ executeWithRetries(lts, pd, compiledStatement);
tracker.endModification(lts);
+ hadVisibleVisit = false;
}
@Override
- public void operation(long lts, long pd, long cd, long opId,
OpSelectors.OperationKind opType)
+ public void operation(Operation operation)
{
- CompiledStatement statement = operationInternal(lts, pd, cd, opId,
opType);
- statements.add(statement.cql());
- Collections.addAll(bindings, statement.bindings());
+ hadVisibleVisit = operation.opKind() !=
OpSelectors.OperationKind.DELETE_PARTITION;
Review Comment:
They are visible since if there is a partition liveness marker, partition's
static column is going to survive. Adding a comment!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
