maedhroz commented on code in PR #24:
URL: https://github.com/apache/cassandra-harry/pull/24#discussion_r1417673577
##########
harry-core/src/harry/data/ResultSetRow.java:
##########
@@ -55,12 +78,26 @@ public ResultSetRow clone()
Arrays.copyOf(vds, vds.length),
Arrays.copyOf(lts, lts.length));
}
+ public boolean equals(Object o)
+ {
+ if (this == o) return true;
+ if (o == null || getClass() != o.getClass()) return false;
+ ResultSetRow that = (ResultSetRow) o;
+ return pd == that.pd &&
+ cd == that.cd &&
+ Arrays.equals(vds, that.vds) &&
+ Arrays.equals(lts, that.lts) &&
+ Arrays.equals(sds, that.sds) &&
+ Arrays.equals(slts, that.slts) &&
+ Objects.equals(visited_lts, that.visited_lts);
+ }
+
public String toString()
Review Comment:
nit: Does `visited_lts` need to be part of the `toString()`, or is it
something that might grow to be potentially huge and not visually friendly? :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]