szymon-miezal commented on code in PR #2957:
URL: https://github.com/apache/cassandra/pull/2957#discussion_r1417027852
##########
pylib/cqlshlib/copyutil.py:
##########
@@ -2130,6 +2136,7 @@ def convert_unknown(val, ct=cql_type):
'map': convert_map,
'tuple': convert_tuple,
'frozen': convert_single_subtype,
+ VectorType.typename: convert_vector,
Review Comment:
I think avoiding divergence when possible is a good habit that's why I am
raising it.
Possibly a better way forward would be to merge it as is and change all the
possible string keys to `typename` references in the subsequent patch. I would
prefer that slightly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
