szymon-miezal commented on code in PR #2957:
URL: https://github.com/apache/cassandra/pull/2957#discussion_r1415923562
##########
pylib/cqlshlib/copyutil.py:
##########
@@ -2130,6 +2136,7 @@ def convert_unknown(val, ct=cql_type):
'map': convert_map,
'tuple': convert_tuple,
'frozen': convert_single_subtype,
+ VectorType.typename: convert_vector,
Review Comment:
> Aslo , I tested what I have said of the modification on this patch, it can
succeed.
Yes, both approaches will make the tests pass.
Note that `UserType` is a class designed for handling User-Defined Types
(UDTs). In this context, the exact type is unknown to us, making it more
suitable for `convert_unknown` rather than a well-defined and well-known vector
type.
In the end, I think using `VectorType.typename` is not that much of an
abuse, it points to a `str` value anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
