maedhroz commented on code in PR #24:
URL: https://github.com/apache/cassandra-harry/pull/24#discussion_r1417751800
##########
harry-core/src/harry/reconciler/PartitionState.java:
##########
@@ -113,18 +126,18 @@ public boolean isEmpty()
return rows.isEmpty();
}
- private Reconciler.RowState updateRowState(Reconciler.RowState
currentState, List<ColumnSpec<?>> columns, long cd, long[] vds, long lts,
boolean writePrimaryKeyLiveness)
+ private Reconciler.RowState updateRowState(Reconciler.RowState
currentState, List<ColumnSpec<?>> columns, long cd, long[] sds, long lts,
boolean writePrimaryKeyLiveness)
Review Comment:
Stumbling over naming here a bit. We have `sds`, and methods calling this w/
the argument `staticVds` or `vds`. `updateRowState()` isn't always called w/
static values (or value descriptors) right? (Aside: Would `vds` for normal
column values and `svds` make sense for static values?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
