dcapwell commented on code in PR #2976:
URL: https://github.com/apache/cassandra/pull/2976#discussion_r1420904079
##########
src/java/org/apache/cassandra/db/compaction/CompactionStrategyManager.java:
##########
@@ -749,8 +763,16 @@ else if (i < a.length)
*/
private void handleFlushNotification(Iterable<SSTableReader> added)
{
- for (SSTableReader sstable : added)
- compactionStrategyFor(sstable).addSSTable(sstable);
+ List<GroupedSSTableContainer> groups = groupSSTables(added);
Review Comment:
this is the actual bug fix. I didn't want to add a new method to do `find +
add` using the correct locking when we already had... just requires grouping.
If there is a reason to avoid the grouping, more than glad to create a new
method to solve this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
