dcapwell commented on code in PR #2976:
URL: https://github.com/apache/cassandra/pull/2976#discussion_r1420906824


##########
src/java/org/apache/cassandra/db/lifecycle/Tracker.java:
##########
@@ -508,6 +508,8 @@ void notifyAdded(Iterable<SSTableReader> added, boolean 
isInitialSSTables)
 
     public void notifySSTableRepairedStatusChanged(Collection<SSTableReader> 
repairStatusesChanged)
     {
+        if (repairStatusesChanged.isEmpty())

Review Comment:
   kept finding we kept triggering notifications constantly with empty state, 
which caused us to lock a lot but do nothing... so I can remove this, but 
figured best to not notify when there is nothing to notify of...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to