smiklosovic commented on code in PR #2977:
URL: https://github.com/apache/cassandra/pull/2977#discussion_r1430321196
##########
src/java/org/apache/cassandra/tools/nodetool/stats/TableStatsPrinter.java:
##########
@@ -167,6 +168,11 @@ protected void printStatsTable(StatsTable table, String
tableDisplayName, String
}
out.println("");
}
+
+ protected String formatMemory(long bytes, boolean humanReadable)
Review Comment:
@zaaath I think this should be called `formatDataSize` or similar, rather
than _memory_.
Also, why does this method needs to be `protected`? It can be `private`.
Whole `DefaultPrinter` is private and that method is not used anywhere but in
`printStatsTable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
