smiklosovic commented on code in PR #2977:
URL: https://github.com/apache/cassandra/pull/2977#discussion_r1430323676
##########
src/java/org/apache/cassandra/tools/nodetool/stats/TableStatsPrinter.java:
##########
@@ -167,6 +168,11 @@ protected void printStatsTable(StatsTable table, String
tableDisplayName, String
}
out.println("");
}
+
+ protected String formatMemory(long bytes, boolean humanReadable)
Review Comment:
Also, could you please take a look at this? (this is an opportunistic fix
here)
`out.printf(indent + " %-" + maxWidth + "s %s%n", "Key", "Size");`
my IDE tells me that this should be used with all `%s` rather than using
concatenating. How is it now does not make a lot of sense if we use `+`
together with `%s`. Should be all on `%s`. There is similar case with
`out.printf(indent + " %-" + maxWidth + "s %s%n", "Key", "Count");`
below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
