maedhroz commented on code in PR #2961:
URL: https://github.com/apache/cassandra/pull/2961#discussion_r1434405724
##########
src/java/org/apache/cassandra/db/guardrails/GuardrailsConfig.java:
##########
@@ -429,4 +429,40 @@ void setMaximumTimestampThreshold(@Nullable
DurationSpec.LongMicrosecondsBound w
*/
void setMinimumTimestampThreshold(@Nullable
DurationSpec.LongMicrosecondsBound warn,
@Nullable
DurationSpec.LongMicrosecondsBound fail);
+
+ /**
+ * @return The threshold to warn when number of referenced indexes
+ * to be searched for non-partition restricted query is greater than
treshold.
+ */
+ int getSaiSSTableIndexesPerQueryWarnThreshold();
+
+ /**
+ * @return The threshold to fail when number of referenced indexes
+ * to be searched for non-partition restricted query is greater than
treshold.
+ */
+ int getSaiSSTableIndexesPerQueryFailThreshold();
+
+ /**
+ * Sets warn and fail thresholds for a guardrail checking number of
referenced indexes
+ * to search for non-partition restricted query.
+ * @param warn value to set for warn threshold
+ * @param fail value to set for fail threshold
+ */
Review Comment:
For all three of these, big thing is removing the language around partition
restrictions, which don't come into play explicitly for this guardrail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
