maedhroz commented on code in PR #2961:
URL: https://github.com/apache/cassandra/pull/2961#discussion_r1434407308


##########
src/java/org/apache/cassandra/db/guardrails/GuardrailsConfig.java:
##########
@@ -429,4 +429,40 @@ void setMaximumTimestampThreshold(@Nullable 
DurationSpec.LongMicrosecondsBound w
      */
     void setMinimumTimestampThreshold(@Nullable 
DurationSpec.LongMicrosecondsBound warn,
                                       @Nullable 
DurationSpec.LongMicrosecondsBound fail);
+
+    /**
+     * @return The threshold to warn when number of referenced indexes
+     * to be searched for non-partition restricted query is greater than 
treshold.
+     */
+    int getSaiSSTableIndexesPerQueryWarnThreshold();
+
+    /**
+     * @return The threshold to fail when number of referenced indexes
+     * to be searched for non-partition restricted query is greater than 
treshold.
+     */
+    int getSaiSSTableIndexesPerQueryFailThreshold();
+
+    /**
+     * Sets warn and fail thresholds for a guardrail checking number of 
referenced indexes
+     * to search for non-partition restricted query.
+     * @param warn value to set for warn threshold
+     * @param fail value to set for fail threshold
+     */
+    void setSaiSSTableIndexesPerQueryThreshold(int warn, int fail);
+
+    /**
+     * Returns whether it is possible to execute a query against indexes 
(secondary or SAI) without specifying
+     * any partition key restrictions.
+     *
+     * @return true if it is possible to execute a query without a partition 
key, false otherwise
+     */
+    boolean getNonPartitionRestrictedQueryEnabled();
+
+    /**
+     * Sets whether it is possible to execute a query against indexes 
(secondary or SAI) without specifying

Review Comment:
   ```suggestion
        * Sets whether it is possible to execute a query against secondary 
indexes without specifying
   ```
   Technically SAI is a secondary index...might as well be general.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to