aweisberg commented on code in PR #74:
URL: https://github.com/apache/cassandra-accord/pull/74#discussion_r1440963766
##########
accord-core/src/main/java/accord/messages/Request.java:
##########
@@ -23,7 +23,16 @@
public interface Request extends Message
{
- void process(Node on, Id from, ReplyContext replyContext);
default long waitForEpoch() { return 0; }
default long knownEpoch() { return waitForEpoch(); }
+ void preProcess(Node on, Id from, ReplyContext replyContext);
+ void process(Node on, Id from, ReplyContext replyContext);
+
+ /**
+ * Process the request without replying back
+ */
+ default void process(Node on)
+ {
+ throw new UnsupportedOperationException();
Review Comment:
I think this belongs in the `LocalRequest` interface not the `Request`
interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
