aweisberg commented on code in PR #74:
URL: https://github.com/apache/cassandra-accord/pull/74#discussion_r1440969184
##########
accord-core/src/main/java/accord/messages/Request.java:
##########
@@ -23,7 +23,16 @@
public interface Request extends Message
{
- void process(Node on, Id from, ReplyContext replyContext);
default long waitForEpoch() { return 0; }
default long knownEpoch() { return waitForEpoch(); }
+ void preProcess(Node on, Id from, ReplyContext replyContext);
Review Comment:
This is used to facilitate an external error handling path that combines
with `MapReduceConsume`.
Seems like it would be better interface wise to add a method that takes all
these parameters and the error, but I can see how that would lead to
duplication and wouldn't be a ton clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
