blambov commented on code in PR #2896:
URL: https://github.com/apache/cassandra/pull/2896#discussion_r1452389586
##########
test/unit/org/apache/cassandra/config/ParseAndConvertUnitsTest.java:
##########
@@ -104,7 +104,8 @@ public void testConfigurationLoaderParser()
assertNull(config.file_cache_size);
assertNull(config.index_summary_capacity);
assertEquals(new DataStorageSpec.LongMebibytesBound(1),
config.prepared_statements_cache_size);
- assertNull(config.key_cache_size);
+ if (config.key_cache_size != null) // null in default test config, 0
in latest
Review Comment:
Done
##########
test/unit/org/apache/cassandra/index/sai/cql/MixedIndexImplementationsTest.java:
##########
@@ -81,6 +83,8 @@ public void shouldAcceptColumnsWithOtherIndex() throws
Throwable
@Test
public void shouldRequireAllowFilteringWithOtherIndex() throws Throwable
{
+ Assume.assumeFalse("Mixed test only makes sense if SAI is not default",
Review Comment:
Done
##########
test/unit/org/apache/cassandra/index/CustomIndexTest.java:
##########
@@ -162,6 +165,8 @@ public void indexReceivesWriteTimeDeletionsCorrectly()
throws Throwable
@Test
public void nonCustomIndexesRequireExactlyOneTargetColumn() throws
Throwable
{
+ Assume.assumeTrue("Test does not work with different default secondary
index",
Review Comment:
Done
##########
test/unit/org/apache/cassandra/cql3/validation/operations/SelectSingleColumnRelationTest.java:
##########
@@ -456,6 +459,8 @@ public void testLargeClusteringINValues() throws Throwable
@Test
public void testMultiplePartitionKeyWithIndex() throws Throwable
{
+ Assume.assumeFalse("SAI does not allow multi-column slice
restrictions",
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
