bereng commented on code in PR #2896:
URL: https://github.com/apache/cassandra/pull/2896#discussion_r1451985653


##########
test/unit/org/apache/cassandra/config/ParseAndConvertUnitsTest.java:
##########
@@ -104,7 +104,8 @@ public void testConfigurationLoaderParser()
         assertNull(config.file_cache_size);
         assertNull(config.index_summary_capacity);
         assertEquals(new DataStorageSpec.LongMebibytesBound(1), 
config.prepared_statements_cache_size);
-        assertNull(config.key_cache_size);
+        if (config.key_cache_size != null)  // null in default test config, 0 
in latest

Review Comment:
   `latest what?` is what came to mind when I read that. Add ticket number to 
the reader can see `latest` refers to a special config set-up. wdyt?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to